[AMD] Upgrade AMD CI docker image #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAUT
force-pushed
the
upgradeAmdCiDocker
branch
from
8c9a2b8
to
736193d
Compare
antiagainst
requested changes
Nov 22, 2024
third_party/proton/csrc/lib/Profiler/RocTracer/RoctracerProfiler.cpp
Outdated
Show resolved
Hide resolved
7 tasks
AlexAUT
force-pushed
the
upgradeAmdCiDocker
branch
from
e2e3290
to
fa22c32
Compare
antiagainst
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5005 this PR just lands the updated docker image and fixes for proton test cases for rocm6.2.
This also switches to ubuntu's default clang toolchain instead of using the one which comes with rocm.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsIt does not touch code.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)